1933年，入凤凰影片公司当杂工，不久转入金球影业公司灯光部任职。此后，又转入启明公司当灯光师。1937年起，相继在中联，华侨等影片公司任摄影师。
参与制作影片
十美恋檀郎
荒岛惊魂
神龙五虎将Five swordsmen
金屋双娇Puzzles of love
武林十三剑The thirteen swords, part one
深闺梦里人The lover ever in her dream
穿金宝扇Gold-braided fan
盲童奇遇记
毒丈夫Thecruel husband
老夫子Oldmaster "Q"
孤星血泪An orphan's tragedy
生死连枝(上集) Between life and death, part one
我要活下去We want to live
天山猿女
大破诛仙阵Duel in Chu Sin
刀下美人魂
人伦Human relationships
银纸万岁Long live money
难为了妹妹My poor younger sister
红灯绿灯Red light, green light
儿女作冰人
豪门怨Thehouse of hatred
火网英雄传Swords of 9 continent
山河恋Memory of my country
弃妇(上集)
海瑞罢官
龙凤合欢花
神童擒凶记
故苑又逢春The renewal of an old garden
俏冤家Acouple of happy enemies
孤雏血泪
夜夜望娘归Mother, come back
危楼春晓In the face of demolition
失足恨Thefall
女间谍第一号Lady spy no. 1
三娘得道
都市两女性Two city girls
紫钗记Thelegend of purple hairpin
钱Money
紫薇园的秋天Autumn comes to Crape Myrtle Garden
学生王子The student prince
第一号女贼The notorious woman thief
暴雨红莲A lily in the storms
爱(上集) Love, (part 1)
锦绣天堂The beautiful heaven
啼笑姻缘A tale of laughter and tears
琴姑下集大结局Madam Kam, the concluding episode
艳尸还魂记A beautiful corpse comes to life
水浒传:智取生辰纲The water margin: booty captured
蛊惑佬寻春The running mob
三笑姻缘Laugh in the sleeve
霸王妖姬The warlord and the beauty
宝莲灯三集The precious lotus lamp, part three
宝莲灯续集The precious lotus lamp, the sequel
宝莲灯Theprecious lotus lamp
孽海遗恨(下集大结局) A Man's betrayal, part two
孽海遗恨上集A man betrayal, part one
烽火佳人The tormented beauty
双枪陆文龙The double-speared Luk Man-lung
离乡情泪Sorrowful wife from village
破镜重圆
点心皇后Queen of tea house
墙Thewall
老婆万岁Viva the better half
巴士奇遇结良缘For sentimental reason
千手奇女子A girl of deceiver
亲情深似海
人鬼恩仇
历劫亲情
大丈夫日记The dairy of a husband
蝶影红梨记Butterfly and red pear blossom
春Spring
金夫人Madame Kam
楼上楼下两相亲The affairs of two families
小夫妻Beware of the husband
改期结婚The postponed wedding
闺房趣史My dearest wife
大地Thegood earth
豪门夜宴Feast of a rich family
情僧偷到潇湘馆The romantic monk
绰头世界
大丈夫日记下集The diary of a husband, part two
情海幽兰Everlasting love
汉武帝梦会卫夫人The dream encounter between Emperor Wu of Han and Lady Wai
电梯情杀案The elevator murder case
雷雨Thunderstorm
路Road
生死连枝(下集大结局) Between life and death part two
落花流水Spring's flight
第七号司机Driver no. 7
情天劫Alove's tragedy
张爱兰巧破黑手党The secret code
爱(续集) Love, the sequel
慈母颂Mother was grand
慈母泪Amother remembers
黑夜怪谈
神秘的凶手
神秘夫人Madam mystery
真假金蝴蝶Gold Butterfly & Gold Butterfly
琴姑(上集) Madam Kam, part one
无敌鸳鸯剑The matchless pair swords
海Sea
寒夜Itwasacold winter night
卿何薄命The ill-fated girl
追凶记Trace of murderer
倒乱乾坤Turning upside down
香城凶影Murderer in town
败家仔
苦海明灯A son is born
红鬃烈马Heng Poh Chuan
秋Autumn
柳毅传书The princess's messenger
春残梦断Anna
阿珍要嫁人Landlady and tenant
长生塔Theimmortality pagoda
金枝玉叶The missing Cinderella
金山大少The chair
花神Thewhite peony
状元巡更
乱世英雄
武林十三剑大结局The thirteen swords, concluding episode
血泪洗残脂
儿女债Themore the merrier
仙童玉女
巫山梦断相思泪The endless love
冷燕飘零As time goes by
西厢记Romance at the Western Chamber
血泪人生A tearful life
血染黄金Blood money
血手套
好冤家Dear love
奸情Adultery
多少柔情多少泪As long as I remember
再生花Aflower reborn
白头情侣White-hair lovers
四姊妹Thefour sisters
司马相如The story of Sima Sheung-yu
可怜天下父母心The great devotion
出谷黄莺Oriole's song
父与子Story of father and son
父母心Parents' hearts
日出Sunrise
少女怀春Romance in the air
夫妻的秘密Happy couples
天长地久Eternal love
工厂皇后Three love affairs
工厂三小姐Three flowers of the factory
小康之家Happy family
小妇人Four daughters
小武士
小姐,先生,师奶
女贼金蝴蝶Golden Butterfly
女人的秘密
大雷雨Bigthunderstorm
十兄弟怒海除魔
十兄弟Tenbrothers
十大姐
八仙闹东海The fighting of the eight gods in the East Sea
妒潮
人海孤鸿The orphan
歌声泪影(下集)
歌声泪影(上集)
九九九命案Dragnet
七小福Theseven kids
一尸五命案Five murders
九九九毒天鹅999 poisonous swan
斗气夫妻
满江红
夜桃源Peach blossom fount by night
难为了妈妈
财来自有方Money will find its way to come
迷楼金粉
两个刁蛮女三气萧月白
佳偶天成
契爷艳史
风雨送魂归
孤岛天堂Orphan Island Paradise
人海万花筒
一丈红
别离人对奈何天= Parting unto sky's end
